Re: [PATCH] Fix guest memory leak and panic

From: Ian Campbell
Date: Tue Oct 18 2011 - 05:47:14 EST


On Tue, 2011-10-18 at 09:36 +0100, Ian Campbell wrote:
> I think the best thing might be to remove the additional ref taking from
> the setter function and audit the previous changes to ensure they
> conform. I'll do that right away and post a fixup patch ASAP.

Sigh, only one out of the ten callers of (__)skb_frag_set_page expects
skb_frag_set_page to take a new reference. I think that's pretty
comprehensive evidence that the current behaviour is unexpected and
wrong.

Sorry about this.

Ian.

8<---------------------------------------------------------