Re: patch] cpusets, cgroups: disallow attaching kthreadd

From: David Rientjes
Date: Tue Oct 18 2011 - 04:16:16 EST


On Tue, 18 Oct 2011, Mike Galbraith wrote:

> Ahem, the buildable copy..
>
> I've been asked to add this toe saver to the trees I work on at least
> until something better comes along. ACK/NACK equally understandable
> given the infrequency of the toe shooting, and user's right to do so.
>
> Off you go, fly or die little patchlet.
>

Heh.

> cpusets, cgroups: disallow attaching kthreadd
>
> Allowing kthreadd to be moved to a non-root group makes no sense, it being
> a global resource, and needlessly leads unsuspecting users toward trouble.
>
> 1. An RT workqueue worker thread spawned in a task group with no rt_runtime
> allocated is not schedulable. Simple user error, but harmful to the box.
>
> 2. A worker thread which acquires PF_THREAD_BOUND can never leave a cpuset,
> rendering the cpuset immortal.
>
> Save the user some unexpected trouble, just say no.
>
> Signed-off-by: Mike Galbraith <efault@xxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/