Re: [RFC][PATCH -next] make pstore/kmsg_dump run after stopping othercpus in panic path

[Chen Gong]

ä 2011/10/17 22:10, Seiji Aguchi åé:
> Hi,
>
> Thank you for giving me a comment.
>
> > I have a stupid question: since you have serialized the process procedure via
> > smp_send_stop, why still using spin_lock_xxx? Maybe preempt_disable/enable is
> > enough?
>
>
> I added spin_lock_init() in panic path for sharing code with other triggers
> such as oops/reboot/emergency_restart because they still need spin_locks.
>
> Do you suggest following code?
>
> <snip>
> If(!panic)
> 	spin_lock_irqsave();
>
>       .
>       .
> If(!panic)
> 	spin_unlock_restore();
> <snip>
>
> I don't stick to current patch.
> So I will resend a patch above if you request.

Yes, it looks more readable.

+	if (reason == KMSG_DUMP_PANIC)
+		raw_spin_lock_init(&logbuf_lock);

above codes look a little bit confused

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/