Re: gpio-ml-ioh: Support interrupt function

[Tomoya MORINAGA]

Hi,

(2011/10/18 5:10), Dan Carpenter wrote:
> The linux-next patch 54be566317b6 "gpio-ml-ioh: Support interrupt
> function" generates a Sparse warning.
>
> +               irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> +                                          GFP_KERNEL);
>                                             ^^^^^^^^^^
>
> The last argument should be a NUMA node, not a GFP_ flag.  I'm not
> sure what the right fix is.  There are currently 5 callers in my
> cscope for this function in linux-next.
>
> 2 pass GFP_KERNEL which is wrong.
> 2 pass 0 which maybe should be cpu_to_node(0)?
> 1 passes -1 which maybe could be NUMA_NO_NODE?
I can understand your saying.
Seeing accepted other drivers, '0' or '-1' is used.
Focusing on GPIO driver, gpio-pca953x.c uses '-1'.

Though I tried to understand source code of irq_alloc_descs,
I can't understand which value we should use.

> Grant,
Could you help me ?

--
tomoya
ROHM Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/