Re: [PATCH] powerpc/mm: remove hack in mmap randomize layout

From: David Miller
Date: Mon Oct 17 2011 - 17:54:13 EST


From: Dan McGee <dpmcgee@xxxxxxxxx>
Date: Mon, 17 Oct 2011 15:17:36 -0500

> Since commit 8a0a9bd4db63bc45e301, this comment in mmap_rnd() does not
> hold true as the value returned by get_random_int() will in fact be
> different every single call. Remove the comment and simplify the code
> back to its original desired form.
>
> This reverts commit a5adc91a4b44b5d1 which is no longer necessary.
>
> Signed-off-by: Dan McGee <dpmcgee@xxxxxxxxx>

Can you please fix up all the other architectures which use the same
logic, because they have simply copied over what powerpc does?

At a minimum, Sparc has two such locations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/