Re: [PATCH] drivers, vmw_balloon.c: Determine page allocation flagcan_sleep outside loop.

[Rakib Mullick]

On Tue, Oct 18, 2011 at 1:31 AM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Tue, 18 Oct 2011, Rakib Mullick wrote:
>
>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
>> index 053d36c..6983d80 100644
>> --- a/drivers/misc/vmw_balloon.c
>> +++ b/drivers/misc/vmw_balloon.c
>> @@ -412,6 +412,7 @@ static int vmballoon_reserve_page(struct vmballoon *b, bool can_sleep)
>>       gfp_t flags;
>>       unsigned int hv_status;
>>       bool locked = false;
>> +     flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP;
>>
>>       do {
>>               if (!can_sleep)
>
> Should be folded in with the declaration of gfp_t flags.
>
> Would you also like to add a might_sleep_if(can_sleep) here?
>
I'm not sure. But, I don't think it's needed here. can_sleep tells
whether alloc_page can sleep or not, which has been determined and
passed by the callee function.


Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/