Re: [PATCH 06/10] mmc-host: move to dma_transfer_direction

[Nicolas Ferre]

On 10/14/2011 07:38 AM, Vinod Koul :
> From: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
> 
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> Cc: Chris Ball <cjb@xxxxxxxxxx>
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
>  drivers/mmc/host/atmel-mci.c    |    9 ++++++---

[..]

> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -681,16 +681,19 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
>  	if (atmci_is_mci2())
>  		mci_writel(host, DMA, MCI_DMA_CHKSIZE(3) | MCI_DMAEN);
>  
> -	if (data->flags & MMC_DATA_READ)
> +	if (data->flags & MMC_DATA_READ) {
>  		direction = DMA_FROM_DEVICE;
> -	else
> +		slave_dirn = DEV_TO_MEM;

It seems that the slave_dirn declaration is missing...

> +	} else {
>  		direction = DMA_TO_DEVICE;
> +		slave_dirn = MEM_TO_DEV;
> +	}
>  
>  	sglen = dma_map_sg(chan->device->dev, data->sg,
>  			   data->sg_len, direction);
>  
>  	desc = chan->device->device_prep_slave_sg(chan,
> -			data->sg, sglen, direction,
> +			data->sg, sglen, slave_dirn,
>  			DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
>  	if (!desc)
>  		goto unmap_exit;

When fixed:

Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

Best regards,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/