Re: [PATCH] spi/spi-ep93xx: add module.h include

[Mika Westerberg]

On Sat, Oct 15, 2011 at 10:23:28PM -0600, Grant Likely wrote:
> On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxx>
> 
> Why?  The commit text needs to explain why the patch is required.

How about following then?

From: Mika Westerberg <mika.westerberg@xxxxxx>
Subject: [PATCHv2] spi/spi-ep93xx: add module.h include

Due to module.h cleanup it is not anymore included implicitly. Drivers who
want to use it need to include it explicitly.

Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxx>
---
 drivers/spi/spi-ep93xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index 1cf6454..11515c5 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -24,6 +24,7 @@
 #include <linux/dmaengine.h>
 #include <linux/bitops.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/workqueue.h>
 #include <linux/sched.h>
-- 
1.7.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/