Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1configs

[Aaro Koskinen]

Hi,

On Fri, 7 Oct 2011, Janusz Krzysztofik wrote:
> Dnia wtorek, 23 sierpnia 2011 o 19:11:47 Kevin Hilman napisaÅ(a):
> > Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> writes:
> > > With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove
> > > ifdefs", access to build time conditionally omitted 'suspend_wakeup'
> > > member of the 'gpio_bank' structure has been placed unconditionally in
> > > function _set_gpio_wakeup(), which is always built. This resulted in the
> > > driver compilation broken for certain OMAP1, i.e., non-OMAP16xx,
> > > configurations.
> > >
> > > Really required or not in previously excluded cases, define this
> > > structure member unconditionally as a fix.
> > >
> > > Tested with a custom OMAP1510 only configuration.
> > >
> > > Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
> >
> > Verified that this fixes a build problem when building for OMAP1
> > (730/850 only)
> >
> > Acked-by: Kevin Hilman <khilman@xxxxxx>

Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

> > Grant, can you queue this as a fix for 3.1-rc?
>
> Sorry for being so late with checking this, but it looks like this patch
> never got into 3.1-rc, as it should, leaving the issue not fixed.
> Any chance for it still being pushed into 3.1?

This patch is one-liner, and still needed to get 3.1-rc9 compiled and
running on e.g. Amstrad E3, so I think it should get into 3.1.

A.