Re: [PATCH v3] usb: add new usb gadget for ACM and mass storage

From: Michal Nazarewicz
Date: Mon Oct 10 2011 - 12:00:23 EST


On Mon, 10 Oct 2011 10:33:01 +0200, Klaus Schwarzkopf <schwarzkopf@xxxxxxxxxxxxxx> wrote:
+static struct usb_device_descriptor device_desc = {
+ .bLength = sizeof device_desc,
+ .bDescriptorType = USB_DT_DEVICE,
+
+ .bcdUSB = cpu_to_le16(0x0200),
+
+ .bDeviceClass = USB_CLASS_COMM,
+ .bDeviceSubClass = 0,
+ .bDeviceProtocol = 0,

Should bDeviceClass, bDeviceSubClass, and bDeviceProtocol have the same
value like in the file multi.c?

.bDeviceClass = USB_CLASS_MISC /* 0xEF */,
.bDeviceSubClass = 2,
.bDeviceProtocol = 1,

IIRC, the reason multi.c has those is because Windows does not recognise
a multi-configuration device with zeros here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/