Re: [PATCH 09/23] mfd/db8500-prcmu: tweak for modem wakeup

From: Linus Walleij
Date: Mon Oct 10 2011 - 07:05:38 EST


On Mon, Oct 10, 2011 at 12:31 PM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:

> Hi Linus,
>> >     if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
>> > -                   msecs_to_jiffies(20000))) {
>> > -           pr_err("prcmu: %s timed out (20 s) waiting for a reply.\n",
>> > +                   msecs_to_jiffies(5000))) {
>> > +           panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
>> > +                   __func__);
>> panic(), really ?
>
> What about this one. Do we really want to panic here ?

Oh I must have lost that patch I wrote converting them all
to pr_crit(). Just sent it out, sorry about this.

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/