Re: [patch] dma/timberdale: free_irq() on an error path

From: Vinod Koul
Date: Fri Oct 07 2011 - 01:05:58 EST


On Fri, 2011-09-23 at 09:16 +0300, Dan Carpenter wrote:
> There was an error path that skipped the free_irq() step by mistake.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
> index 6dbdf45..a4a398f 100644
> --- a/drivers/dma/timb_dma.c
> +++ b/drivers/dma/timb_dma.c
> @@ -762,7 +762,7 @@ static int __devinit td_probe(struct platform_device *pdev)
> if ((i % 2) == pchan->rx) {
> dev_err(&pdev->dev, "Wrong channel configuration\n");
> err = -EINVAL;
> - goto err_tasklet_kill;
> + goto err_free_irq;
> }
>
> td_chan->chan.device = &td->dma;
Applied thanks

--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/