Re: [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structuresfor omap3

From: Munegowda, Keshava
Date: Tue Oct 04 2011 - 07:57:27 EST


On Fri, Sep 30, 2011 at 10:47 PM, Kevin Hilman <khilman@xxxxxx> wrote:
> "Munegowda, Keshava" <keshava_mgowda@xxxxxx> writes:
>
> [...]
>
>>>> +
>>>> +static struct omap_hwmod_ocp_if omap34xx_f_cfg__usb_tll_hs = {
>>>> +     .clk            = "usbtll_ick",
>>>> +     .user           = OCP_USER_MPU,
>>>> +     .flags          = OCPIF_SWSUP_IDLE,
>>>> +};
>>>
>>> Does this really need OCPIF_SWSUP_IDLE?  If so, then there is a hardware
>>> bug, and some explanation is needed.
>>
>>
>> it was not allowing enter usbhs pw domain to enter to low power idle mode; so
>> I add a comment here.
>>
>
> When you add this comment, please be sure it describes *why* the power
> domain was not hitting the target power state, and reference any
> relevant eerrata.

I will add the errata description and id

regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/