Re: [patch 00/10] memcg naturalization -rc4

From: Andrew Morton
Date: Mon Oct 03 2011 - 19:11:58 EST


On Thu, 29 Sep 2011 23:00:54 +0200
Johannes Weiner <jweiner@xxxxxxxxxx> wrote:

> this is the fourth revision of the memory cgroup naturalization
> series.

The patchset removes 20 lines from include/linux/*.h and removes
exactly zero lines from mm/*.c. Freaky.

If we were ever brave/stupid emough to make
CONFIG_CGROUP_MEM_RES_CTLR=y unconditional, how much could we simplify
mm/?

We are adding bits of overhead to the CONFIG_CGROUP_MEM_RES_CTLR=n case
all over the place. This patchset actually decreases the size of allnoconfig
mm/built-in.o by 1/700th.

A "struct mem_cgroup" sometimes gets called "mem", sometimes "memcg",
sometimes "mem_cont". Any more candidates? Is there any logic to
this?


Anyway... it all looks pretty sensible to me, but the timing (at
-rc8!) is terrible. Please keep this material maintained for -rc1, OK?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/