Re: [PATCH] perf: fix broken number of samples for perf report -n

[Arnaldo Carvalho de Melo]

Em Mon, Oct 03, 2011 at 11:38:15AM +0200, Stephane Eranian escreveu:
> 
> The perf report -n option was broken because it was not reporting
> the correct number of samples depending on the sorting mode. By
> default, samples are sorted by comm,dso,sym. That means that
> samples for the same command (binary) get collapsed.
> 
> The hists__collapse_insert_entry() had a bug whereby
> it was aggregating the number of events observed (periods)
> but not the number of samples. Consequently, the number
> of samples reported could be below reality. The percentage
> remained correct because based on the periods.
> 
> This patch fixes the problem by also aggregating
> the number of samples. Here is an example:

Eagle eyes, this collapse_resort thing has its issues, been fighting
some last week, making 'perf top' use struct hist_entry, killing code.

Double checking that now, thanks!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/