[RFCv3][PATCH 2/4] add string_get_size_pow2()

From: Dave Hansen
Date: Fri Sep 30 2011 - 20:09:30 EST



This is a specialized version of string_get_size().

It only works on powers-of-two, and only outputs in
KiB/MiB/etc... Doing it this way means that we do
not have to do any division like string_get_size()
does.

Signed-off-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
---

linux-2.6.git-dave/include/linux/string_helpers.h | 1
linux-2.6.git-dave/lib/string_helpers.c | 23 ++++++++++++++++++++++
2 files changed, 24 insertions(+)

diff -puN include/linux/string_helpers.h~string_get_size-pow2-1 include/linux/string_helpers.h
--- linux-2.6.git/include/linux/string_helpers.h~string_get_size-pow2-1 2011-09-30 17:03:00.511708995 -0700
+++ linux-2.6.git-dave/include/linux/string_helpers.h 2011-09-30 17:03:00.535708956 -0700
@@ -10,6 +10,7 @@ enum string_size_units {
STRING_UNITS_2, /* use binary powers of 2^10 */
};

+u64 string_get_size_pow2(u64 size, char *unit_ret);
int string_get_size(u64 size, enum string_size_units units,
char *buf, int len);

diff -puN lib/string_helpers.c~string_get_size-pow2-1 lib/string_helpers.c
--- linux-2.6.git/lib/string_helpers.c~string_get_size-pow2-1 2011-09-30 17:03:00.515708988 -0700
+++ linux-2.6.git-dave/lib/string_helpers.c 2011-09-30 17:03:00.535708956 -0700
@@ -25,6 +25,29 @@ static char *__units_str(enum string_siz
return buf;
}

+u64 string_get_size_pow2(u64 size, char *unit_ret)
+{
+ int log2;
+ int unit_index;
+
+ if (!size) {
+ __units_str(STRING_UNITS_2, unit_ret, 0);
+ return 0;
+ } else {
+ log2 = ilog2(size);
+ }
+
+ /* KiB is log2=0->9, MiB is 10->19, etc... */
+ unit_index = log2 / 10;
+ __units_str(STRING_UNITS_2, unit_ret, unit_index);
+
+ /* 512 aka 2^9 is the largest integer without
+ * overflowing to the next power-of-two, so
+ * use %10 to make it max out there */
+ return (1 << (log2 % 10));
+}
+EXPORT_SYMBOL(string_get_size_pow2);
+
/**
* string_get_size - get the size in the specified units
* @size: The size to be converted
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/