Re: [PATCH 2/5 v12] arm: omap: usb: ehci and ohci hwmod structures for omap3

[Kevin Hilman]

"Munegowda, Keshava" <keshava_mgowda@xxxxxx> writes:

[...]

>>> +
>>> +static struct omap_hwmod_ocp_if omap34xx_f_cfg__usb_tll_hs = {
>>> +   .clk      Â= "usbtll_ick",
>>> +   .user      = OCP_USER_MPU,
>>> +   .flags     Â= OCPIF_SWSUP_IDLE,
>>> +};
>>
>> Does this really need OCPIF_SWSUP_IDLE? ÂIf so, then there is a hardware
>> bug, and some explanation is needed.
>
>
> it was not allowing enter usbhs pw domain to enter to low power idle mode; so
> I add a comment here.
>

When you add this comment, please be sure it describes *why* the power
domain was not hitting the target power state, and reference any
relevant eerrata.

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/