Re: [PATCH v13 2/4] PM: Introduce devfreq: generic DVFS framework with device-specific OPPs

From: Rafael J. Wysocki
Date: Fri Sep 30 2011 - 12:52:42 EST


On Friday, September 30, 2011, xiaojiang wrote:
> On 2011?09?29? 20:18, MyungJoo Ham wrote:
> > +/**
> > + * find_device_devfreq() - find devfreq struct using device pointer
> > + * @dev: device pointer used to lookup device devfreq.
> > + *
> > + * Search the list of device devfreqs and return the matched device's
> > + * devfreq info. devfreq_list_lock should be held by the caller.
> > + */
> > +static struct devfreq *find_device_devfreq(struct device *dev)
> > +{
> > + struct devfreq *tmp_devfreq;
> > +
> > + if (unlikely(IS_ERR_OR_NULL(dev))) {
> > + pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
> > + return ERR_PTR(-EINVAL);
> > + }
> > + WARN(!mutex_is_locked(&devfreq_list_lock),
> > + "devfreq_list_lock must be*loced*.");
> A typo, it should be locked.

Thanks, I'll fix it up.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/