Re: [PATCH] sched/kthread: Complain loudly when others violate ourflags

From: Peter Zijlstra
Date: Fri Sep 30 2011 - 05:05:22 EST


On Fri, 2011-09-30 at 01:55 -0700, Tejun Heo wrote:
> Hello, Peter.
>
> On Fri, Sep 30, 2011 at 10:34:59AM +0200, Peter Zijlstra wrote:
> > On Thu, 2011-09-29 at 21:14 -0700, Tejun Heo wrote:
> > > It's rather complicated due to the way workqueues have been used. You
> > > can't tell whether a work really needs to be pinned to one cpu for
> > > correctness until actual cpu hotplug time as wq users are expected to
> > > flush such work items from hotplug notifiers, so wq workers should be
> > > pinned on the respective cpus while the cpus are up but also need to
> > > step aside once unplug notifiers are finished.
> >
> > That really is crack, and I've always said so.
> >
> > How about we fix that utter workqueue unplug nightmare..
>
> The patch is corrupt (=20/=3D's). Can you please re-send?

Fucking mailer insists on quoted-printable for plain text :/

I've got something like the below awk in my mail->patch pipe:

/Content-Transfer-Encoding:.*quoted-printable.*/ {
decode = 1;
}
// {
tmp = $0
if (!decode) {
print tmp
next
}
if (concat) {
tmp = last tmp
concat = 0;
}
if (tmp ~ /=$/) {
concat = 1;
gsub("=$", "", tmp);
}
offset = 0;
while (match(tmp, /=[[:xdigit:]][[:xdigit:]]/, a)) {
if (a[0] < offset)
break;
hex = substr(a[0], 2)
char = sprintf("%c", strtonum("0x"hex))
gsub(a[0], char, tmp)
offset = a[0];
}
if (concat) {
last = tmp
next
}
print tmp
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/