Re: [PATCH] workqueue: Restore cpus_allowed mask for sleepingworkqueue rescue threads

[Tejun Heo]

On Fri, Sep 30, 2011 at 09:54:21AM +0100, Ripduman Sohan wrote:
> Tejun Heo <tj@xxxxxxxxxx> wrote:
> 
> > Hmmm... indeed.  This can cause an unnecessary wakeup / migration on
> > an isolated CPU when another CPU asks for the rescuer, so yeah it
> > makes sense to change the behavior.  BTW, why didn't the original
> > patch simply use set_cpus_allowed_ptr(cpu_all_mask)?
> > 
> 
> Because while at present all (bound) rescuer threads have an
> associated workqueue on each CPU, I didn't want to assume this
> arrangement would _always_ be the case.  It was my thinking that for
> bound threads, iterating over the CPUs to only set those that have
> an associated workqueue for the rescuer would insulate agsinst any
> future case where rescuer threads may be bound to a subset of CPUs.

On which CPU a rescuer is doesn't matter at all.  Using cpu_all_mask
is good enough.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/