[PATCH] kernel/groups.c: Minor bugfix for overflow in binary search

[Josh Zimmerman]

From: Josh Zimmerman

Fixed possible unsigned int overflow bug. (2 + 2^(32) - 1)/2 results in overflow; 2 + (2^(32)-1-2)/2 does not.

Signed-off-by: Josh Zimmerman <joshz@xxxxxxx>

---

--- kernel/groups.c.orig	2011-09-29 23:58:45.000000000 -0400
+++ kernel/groups.c	2011-09-29 23:59:13.000000000 -0400
@@ -142,7 +142,7 @@ int groups_search(const struct group_inf
 	left = 0;
 	right = group_info->ngroups;
 	while (left < right) {
-		unsigned int mid = (left+right)/2;
+		unsigned int mid = left +  (right - left)/2;
 		if (grp > GROUP_AT(group_info, mid))
 			left = mid + 1;
 		else if (grp < GROUP_AT(group_info, mid))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/