Re: [PATCH] Smack: fix domain transfer issues

From: Jarkko Sakkinen
Date: Thu Sep 29 2011 - 09:57:21 EST


On Thu, 29 Sep 2011, Stephen Smalley wrote:

On Thu, 2011-09-29 at 11:26 +0300, Jarkko Sakkinen wrote:
MNT_NOSUID should be checked.

Doubtful, as Smack and capabilities are completely orthogonal, right?
Even for SELinux, the nosuid check is a bit of a nuisance.

What I'm planning to do is to not switch
domain if filesystem is mounted with nosuid.
Same logic as prepare_binprm does for suid
and sgid bits.

Also, I'll plan to
implement permission check for ptrace but in the
scope of this patch.

Still no transition or entrypoint checks, open file revalidation, parent
death signal clearing, ...?

I've already added death signal clearing to the
next-to-be-submitted revision of this patch.
I'm planning to implemented flushing of
non-permissible files and signals as two separate
patches later on (in the near future however).

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/