Re: [PATCH 8/8] regmap: Ensure we scream if we enable cachebypass/only at the same time

[Mark Brown]

On Thu, Sep 29, 2011 at 10:39:13AM +0100, Dimitris Papastamos wrote:

>  void regcache_cache_only(struct regmap *map, bool enable)
>  {
> +	BUG_ON(map->cache_bypass && enable);
>  	mutex_lock(&map->lock);

I'd move these inside the lock otherwise there's an enable/enable race
where two threads check that things are safe simultaneously.  I'd also
change to WARN_ON(), if nothing else it's hard to see BUG_ON()s that
occur prior to console output and PMICs are likely to trigger that sort
of stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/