Re: [PATCH 2/2] ASoC: Add BUG() assertion if max98095_get_bq_channelreturns -EINVAL

[Dave Young]

On Thu, Sep 29, 2011 at 7:19 AM, Ryan Mallon <rmallon@xxxxxxxxx> wrote:
> On 29/09/11 00:02, Axel Lin wrote:
>> The callers use the return value of max98095_get_bq_channel as array index to
>> access max98095->dai[] array.
>> Add BUG() assertion for out of bound access of max98095->dai[] array.
>
> Same here, fix the problem in the callers.
>
> ----
> Check the return value of max98095_get_bq_channel in the callers and
> propagate any errors up. Remove the BUG_ON(channel > 1) since
> max98095_get_bq_channel never returns a value larger than 1.
>
> Signed-off-by: Ryan Mallon <rmallon@xxxxxxxxx>
> ---
>
> diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c
> index 668434d..55eccea 100644
> --- a/sound/soc/codecs/max98095.c
> +++ b/sound/soc/codecs/max98095.c
> @@ -2014,7 +2014,8 @@ static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol,
> Â Â Â Âint fs, best, best_val, i;
> Â Â Â Âint regmask, regsave;
>
> - Â Â Â BUG_ON(channel > 1);
> + Â Â Â if (channel < 0)
> + Â Â Â Â Â Â Â return channel;

If use BUG() happens in  max98095_get_bq_channel, it will not return here?

>
> Â Â Â Âif (!pdata || !max98095->bq_textcnt)
> Â Â Â Â Â Â Â Âreturn 0;
> @@ -2069,6 +2070,9 @@ static int max98095_get_bq_enum(struct snd_kcontrol *kcontrol,
> Â Â Â Âint channel = max98095_get_bq_channel(kcontrol->id.name);
> Â Â Â Âstruct max98095_cdata *cdata;
>
> + Â Â Â if (channel < 0)
> + Â Â Â Â Â Â Â return channel;
> +
> Â Â Â Âcdata = &max98095->dai[channel];
> Â Â Â Âucontrol->value.enumerated.item[0] = cdata->bq_sel;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Regards
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/