Re: [PATCH v3 06/24] C6X: early boot code

[Mark Salter]

On Wed, 2011-09-28 at 15:26 +0200, Arnd Bergmann wrote:
> On Tuesday 27 September 2011, Mark Salter wrote:
> 
> > +int c6x_num_cores;
> > +EXPORT_SYMBOL(c6x_num_cores);
> > +
> > +unsigned int c6x_silicon_rev;
> > +EXPORT_SYMBOL(c6x_silicon_rev);
> > +
> > +/*
> > + * Device status register. This holds information
> > + * about device configuration needed by some drivers.
> > + */
> > +unsigned int c6x_devstat;
> > +EXPORT_SYMBOL(c6x_devstat);
> 
> > +unsigned int ticks_per_ns_scaled;
> > +EXPORT_SYMBOL(ticks_per_ns_scaled);
> > +
> > +unsigned int c6x_core_freq;
> > +EXPORT_SYMBOL(c6x_core_freq);
> 
> These all look like they are used internally (maybe not
> ticks_per_ns_scaled) so it would be more appropriate to make
> them EXPORT_SYMBOL_GPL.

Hmm, we don't need to export c6x_core_freq at all.

c6x_silicon_rev is needed by drivers (though none in the current
patch series) to deal with silicon errata.

c6x_devstat has pin-strap config info some drivers may need.

ticks_per_ns_scale is used in udelay/mdelay.

--Mark


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/