Re: [PATCH 1/3] mfd: allow mfd_cell association with device tree node

From: Daniel Drake
Date: Tue Sep 27 2011 - 14:25:10 EST


On Tue, Sep 27, 2011 at 7:14 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Sep 27, 2011 at 05:44:04PM +0100, Daniel Drake wrote:
>
>> However, it does take Mark's suggestion into account that the mfd
>> should have some clear representation in the device tree. For us it
>> already did have (naturally), but this wasn't reflected in my earlier
>> patch. It is now - the location of the vx855-gpio node is based on
>> finding the mfd node and going from there.
>
> Why not just kmemdup() the template you're using rather than modifying
> it in place?

Could do, but is there any point in this case? I'm not seeing it. The
"template" is already being modified in this way in the current driver
as well.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/