Re: [PATCH][RT] ring-buffer: Convert reader_lock from raw_spin_lockinto spin_lock

[Thomas Gleixner]

On Tue, 27 Sep 2011, Steven Rostedt wrote:
> +	/*
> +	 * If an NMI die dumps out the content of the ring buffer
> +	 * do not grab locks. We also permanently disable the ring
> +	 * buffer too. A one time deal is all you get from reading
> +	 * the ring buffer from an NMI.
> +	 */
> +	if (!ok_to_lock()) {
> +		if (spin_trylock_irqsave(&cpu_buffer->reader_lock, *flags))
> +			return 1;
> +		printk("Dumping ring buffer from unsafe context\n");
> +		printk("Disabling new ring buffer writes\n");

And what exaclty is the point of these printks/ Aside of that they are
missing KERN_WTF before the string.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/