Re: [PATCH] udf: enable error print in udf_read_tagged().

[Joe Perches]

On Wed, 2011-09-28 at 00:46 +0900, Namjae Jeon wrote:
> While reading metadata, if a problem occurs, Print out only one of the five case.(It also does not show a checksum properly.)
[]
> diff --git a/fs/udf/misc.c b/fs/udf/misc.c
[]
> @@ -211,7 +212,7 @@ struct buffer_head *udf_read_tagged(struct super_block *sb, uint32_t block,
>  
>  	bh = udf_tread(sb, block);
>  	if (!bh) {
> -		udf_debug("block=%d, location=%d: read failed\n",
> +		printk(KERN_ERR "block=%d, location=%d: read failed\n",

The other printk in this module uses a "udf: " prefix.

I suggest that
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
is added before any include and these
conversions use pr_err() instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/