Re: [PATCH] staging: comedi: Added log subjects to printk()s in pcmmio

[morbid-rsa]

> The KERN_ERR stuff is only supposed to be used at the start of the
> line of output. Â(The previous KERN_INFO printk didn't have a new
> line at the end).
>
> All this code needs to be rewritten so each printk() only prints
> one line. ÂOtherwise you could get messages printed out in the
> middle of other messages and it looks like crap.
>

*args*, sorry for messing it up, I will take care of it.

> This code is trickier than it looks. ÂQuite a few newbies have run
> into trouble here. ÂMy advice is to start with something that looks
> tricky so at least if you mess up, you were doing something awesome.
> :)
>
> regards,
> dan carpenter
>
>

Thanks for the advice :D

regards,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/