Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespaceaware (v2)

From: Greg KH
Date: Mon Sep 26 2011 - 19:47:04 EST


On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote:
> Add to the dev_state and alloc_async structures the user namespace
> corresponding to the uid and euid. Pass these to kill_pid_info_as_uid(),
> which can then implement a proper, user-namespace-aware uid check.
>
> Changelog:
> Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace,
> uid, and euid each separately, pass a struct cred.
> Sep 26: Address Alan Stern's comments: don't define a struct cred at
> usbdev_open(), and take and put a cred at async_completed() to
> ensure it lasts for the duration of kill_pid_info_as_cred().
>
> Signed-off-by: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>

I have no objection to this, is it going to go through your tree, or
somewhere else?

If so, please add:
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
to it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/