Re: [PATCH v5 3.1.0-rc4-tip 1/26] uprobes: Auxillary routines toinsert, find, delete uprobes

From: Srikar Dronamraju
Date: Mon Sep 26 2011 - 12:34:30 EST


* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2011-09-26 15:35:15]:

> On Tue, 2011-09-20 at 17:29 +0530, Srikar Dronamraju wrote:
> > +static struct uprobe *__find_uprobe(struct inode * inode, loff_t offset)
>
> Here and elsewhere, your whitespace is off, it should read:
>
> struct inode *inode
>
> I think checkpatch will inform you of this, but I didn't check.
>

I have run checkpatch.pl --strict on all the patches and it doesnt
report them.

However I do see these whitespace in three places definitions for
write_opcode, __find_uprobe, and find_uprobe.

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/