Re: [patch]mm: add more blk plug

[Christoph Hellwig]

On Mon, Sep 26, 2011 at 03:38:47PM +0800, Shaohua Li wrote:
> On Mon, 2011-09-26 at 15:30 +0800, Christoph Hellwig wrote:
> > On Mon, Sep 26, 2011 at 10:30:26AM +0800, Shaohua Li wrote:
> > > Some filesystems implement .writepages. We don't have blk plug
> > > in such filesystems for .writepages.
> > 
> > Please add the plugging in the actual ->writepages instances.
> there are several filesystems have ->writepages. Can you share an hint
> why we don't add plugging in the do_writepages?

Because do_writepages is completely generic code with no knowledge of
block I/O.  I really don't want to have block plugging be intimately
tied into core VM/writeback code all over.  We've been there with
->sync_page, and it was a major pain - nevermind the additional (small)
overhead for the not block based filesystems.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/