Re: [PATCH] ceph/super.c: quiet sparse noise

From: Sage Weil
Date: Fri Sep 23 2011 - 15:06:47 EST


Applied, thanks!

sage

On Fri, 23 Sep 2011, H Hartley Sweeten wrote:

> Quiet the sparse noise:
>
> warning: symbol 'create_fs_client' was not declared. Should it be static?
> warning: symbol 'destroy_fs_client' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Sage Weil <sage@xxxxxxxxxxxx>
> ceph-devel@xxxxxxxxxxxxxxx
>
> ---
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index e0a6a06..bbc1b78 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -426,7 +426,7 @@ static int extra_mon_dispatch(struct ceph_client *client, struct ceph_msg *msg)
> /*
> * create a new fs client
> */
> -struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
> +static struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
> struct ceph_options *opt)
> {
> struct ceph_fs_client *fsc;
> @@ -502,7 +502,7 @@ fail:
> return ERR_PTR(err);
> }
>
> -void destroy_fs_client(struct ceph_fs_client *fsc)
> +static void destroy_fs_client(struct ceph_fs_client *fsc)
> {
> dout("destroy_fs_client %p\n", fsc);
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/