Re: [PATCH 08/10] drbd: Introduce protocol version 100 headers

[Kyle Moffett]

Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@xxxxxxxxxx> wrote:
> From: Andreas Gruenbacher <agruen@xxxxxxxxxx>
>
> Signed-off-by: Philipp Reisner <philipp.reisner@xxxxxxxxxx>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>
> ---
> Âdrivers/block/drbd/drbd_int.h   Â|  Â8 ++++++++
> Âdrivers/block/drbd/drbd_main.c   |  31 +++++++++++++++++++++++++------
> Âdrivers/block/drbd/drbd_receiver.c | Â 14 ++++++++++++--
> Âinclude/linux/drbd.h        |  Â1 +
> Â4 files changed, 46 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index 9868518..7d679c5 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -307,6 +307,14 @@ struct p_header95 {
> Â Â Â Âu32 Â Â Â vol_n_len; Â Â/* big endian: high byte = volume; remaining 24 bit = length */
> Â} __packed;
>
> +struct p_header100 {
> + Â Â Â u32 Â Â Â magic;
> + Â Â Â u16 Â Â Â volume;
> + Â Â Â u16 Â Â Â command;
> + Â Â Â u32 Â Â Â length;
> + Â Â Â u32 Â Â Â pad;
> +} __packed;
> +

This commit also needs additional log message text,
specifically something that indicates what is new and
different between the protocol 95 and protocol 100
headers.  (IE: Why was the change made?)

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/