Re: [PATCH 10/10] drbd: For protocol versions before 100, use mixedheader versions

From: Kyle Moffett
Date: Fri Sep 23 2011 - 13:25:11 EST


On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@xxxxxxxxxx> wrote:
> Previous versions of drbd are using version 80 headers for all packets
> short enough for protocol 80. ÂThey support both header versions in
> worker context, but only version 80 headers in asynchronous context.
> For backwards compatibility, continue to use version 80 headers for
> short packets before protocol version 100.
>
> From protocol version 100 on, use the same header version for all
> packets.

If I understand it correctly, this patch fixes a backwards compat bug in
code introduced 2 patches earlier:
[PATCH 08/10] drbd: Introduce protocol version 100 headers

Therefore this patch (and its commit message) should just be rolled into
that one to prevent the bug in the first place.

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/