RE: [PATCH 15/19] plat-pxa: break out GPIO driver specifics

From: Haojian Zhuang
Date: Thu Sep 22 2011 - 22:44:32 EST




>-----Original Message-----
>From: Eric Miao [mailto:eric.y.miao@xxxxxxxxx]
>Sent: 2011å9æ21æ 10:05 PM
>To: Linus Walleij; Haojian Zhuang
>Cc: Linus Walleij; Grant Likely; linux-kernel@xxxxxxxxxxxxxxx; linux-
>arm-kernel@xxxxxxxxxxxxxxxxxxx; Lee Jones; Russell King
>Subject: Re: [PATCH 15/19] plat-pxa: break out GPIO driver specifics
>
>On Tue, Sep 20, 2011 at 4:45 PM, Linus Walleij <linus.walleij@xxxxxxxxxx>
>wrote:
>> On Wed, Aug 10, 2011 at 4:38 PM, Eric Miao <eric.y.miao@xxxxxxxxx>
>wrote:
>>> On Wed, Aug 10, 2011 at 8:18 PM, Linus Walleij
>>> <linus.walleij@xxxxxxxxxxxxxx> wrote:
>>>> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>>>
>>>> The <mach/gpio.h> file is included from upper directories
>>>> and deal with generic GPIO and gpiolib stuff. Break out the
>>>> platform and driver specific defines and functions into its own
>>>> header file.
>>>>
>>>> Cc: Eric Miao <eric.y.miao@xxxxxxxxx>
>>>> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
>>>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>>
>>> I think there is better way around this, am working on it with
>several
>>> patches already, will release soon.
>>
>> Anything happening on this front or shall I update this patch set?
>
>Hi Linus,
>
>Several cleanup patches in my local tree but I didn't manage to find
>time to finish the series. Please go ahead update the patch set. We
>can fix the problems later.
>
>Haojian,
>
>Could you help on generalize the GPIO support code for PXA? Generally,
>the goals are:
>
>1. independent of <mach/gpio.h>, i.e. no #include <mach/gpio.h> so
>to support multiple sub-arch in a single kernel, that's to say -
>possible
>to build a single kernel supporting both mach-pxa/ and mach-mmp/
>
>2. as a result of 1), independent of <plat/gpio.h>
>
OK. I'll follow this.

>Thanks
>- eric
>
>>
>> Yours,
>> Linus Walleij
>>
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i