Re: [PATCH] perf: make perf.data more self-descriptive (v5)

[Andi Kleen]

Stephane Eranian <eranian@xxxxxxxxxx> writes:

> The goal of this patch is to include more information
> about the host environment into the perf.data so it is
> more self-descriptive. Overtime, profiles are captured
> on various machines and it becomes hard to track what
> was recorded, on what machine and when.

I read it near completely.

The only weird thing were the .byte coded push/pops 
in CPUID.

Also the /proc parser doesn't seem very robust, 
e.g. strstr is not a good way to check for a field.

And the code reading /proc lines with fgets should
likely use getline()

Then the bswap code would be much nicer inside a macro.

Other than that it looks good.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/