Re: [PATCH] debug_core: Add warn message for CONFIG_DEBUG_RODATA enable

[Dongdong Deng]

On Thu, Sep 22, 2011 at 3:50 PM,  <libfetion@xxxxxxxxx> wrote:
> From: Dongdong Deng <libfetion@xxxxxxxxx>
>
> The CONFIG_DEBUG_RODATA will limit KGDB/KDB's set breakpoint function,
> and CONFIG_DEBUG_RODATA and CONFIG_KGDB could survive together.
>
> Thus most of new user of KGDB/KDB get the set_breakpoint problem
> caused by CONFIG_DEBUG_RODATA, and them have to send mail to
> kgdb/kdb's mail-list for help.
>
> This patch just adds an extra printk message to warn above case,
> in order to provide some useful diagnostics to kgdb/kdb user.
>
> Signed-off-by: Dongdong Deng <libfetion@xxxxxxxxx>
> ---
> Âkernel/debug/debug_core.c | Â Â5 +++++
> Â1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index bad6786..c2d98c1 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -899,6 +899,11 @@ int kgdb_register_io_module(struct kgdb_io *new_dbg_io_ops)
> Â Â Â Âif (kgdb_break_asap)
> Â Â Â Â Â Â Â Âkgdb_initial_breakpoint();
>
> +#ifdef CONFIG_DEBUG_RODATA
> + Â Â Â printk(KERN_WARNING "kgdb: May need to disable CONFIG_DEBUG_RODATA"
> + Â Â Â Â Â Â Â Â Â Â Â " in order to set breakpoints.\n");
> +#endif
> +
> Â Â Â Âreturn 0;
> Â}
> ÂEXPORT_SYMBOL_GPL(kgdb_register_io_module);
> --
> 1.7.1
>


Hi Tim,

I am thinking about the case of KGDB, not only the KDB.

How about this patch?  -- add the extra printk message to the debug_core init.

When debug_core init, and  check the CONFIG_DEBUG_RODATA was enabled,
then warn the user that breakpoints will not work...

If it is OK to you,  could you should Signed-off for this patch.  :-)

-Dongdong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/