Re: [PATCH 3/3] arm/tegra: Move "gpio-names.h" into <mach/gpio-tegra.h>

From: Olof Johansson
Date: Wed Sep 21 2011 - 16:14:45 EST


Hi,

On Wed, Sep 21, 2011 at 12:33 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote:
> This centralizes all SoC-level GPIO-related definitions into a single
> header file.
>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
>
>  arch/arm/mach-tegra/gpio-names.h              |  247 -------------------------
>  arch/arm/mach-tegra/include/mach/gpio-tegra.h |  225 ++++++++++++++++++++++
>  11 files changed, 226 insertions(+), 257 deletions(-)
>  delete mode 100644 arch/arm/mach-tegra/gpio-names.h

The main reason that gpio-names.h was only in the mach directory and
not under include in the first place, is to discourage use outside of
the base platform code and board definitions.

There should be no need for drivers and non-mach-tegra code to use the
file, so doing a current-directory include of it should be OK. Or do
you have other plans for it?


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/