Re: xen_biovec_phys_mergeable not exported

[Jens Axboe]

On 2011-09-20 22:25, Matthew Wilcox wrote:
> 
> In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE().  If CONFIG_XEN
> is defined, it references xen_biovec_phys_mergeable() which is not
> EXPORT_SYMBOL.  I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
> to be calling from a module that implements a bio-based block driver,
> so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
> the Xen code when I submit the driver.
> 
> Does anyone have a different opinion on this?

Yep, lets just export it for now. Long term, that functionality will be
moving back into the block layer when we unify the queuing models.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/