Re: [PATCH v1 4/4] target: check hex2bin result

[Andy Shevchenko]

On Tue, Sep 20, 2011 at 10:52 PM, Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:
> Now that hex2bin does error checking, on error add debugging error msg.
>
> Changelog v1:
> - hex2bin now returns an int
>
> Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>
> ---
> Âdrivers/target/target_core_fabric_lib.c | Â 11 +++++++++--
> Â1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
> index c4ea3a9..17658ca 100644
> --- a/drivers/target/target_core_fabric_lib.c
> +++ b/drivers/target/target_core_fabric_lib.c
> @@ -63,6 +63,7 @@ u32 sas_get_pr_transport_id(
> Â Â Â Âunsigned char *buf)
> Â{
> Â Â Â Âunsigned char *ptr;
> + Â Â Â bool ret;
I'm sorry for this, but I guess you meant int?
>
> Â Â Â Â/*
> Â Â Â Â * Set PROTOCOL IDENTIFIER to 6h for SAS

> @@ -158,6 +161,8 @@ u32 fc_get_pr_transport_id(
> Â Â Â Âunsigned char *ptr;
> Â Â Â Âint i;
> Â Â Â Âu32 off = 8;
> + Â Â Â bool ret;
Ditto.
> +
> Â Â Â Â/*
> Â Â Â Â * PROTOCOL IDENTIFIER is 0h for FCP-2
> Â Â Â Â *
Otherwise have my Acked-by. I think Andrew also will be happy.


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/