Re: [PATCH] dmaengine i.MX DMA/SDMA: add missing include of linux/module.h

From: Axel Lin
Date: Tue Sep 20 2011 - 09:23:17 EST


2011/9/5 Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>:
> On Mon, 2011-09-05 at 21:32 +0800, Axel Lin wrote:
>> 2011/9/5 Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>:
>> > On Tue, 2011-08-30 at 15:08 +0800, Axel Lin wrote:
>> >> Add missing include of linux/module.h to fix build error.
>> > I don't see this build error in my tree (based on rc4), In which config
>> > is this seen?
>> The patch is against linux-next tree.
>> I got the build error by "make imx_v4_v5_defconfig" on linux-next tree
>> ( next-20110831 )
> Sorry I am not able to find it, can you please point me to archives..
Hi Vinod,
Currently you can get linux-next tree at
git://github.com/sfrothwell/linux-next.git
( http://linux.f-seidel.de/linux-next/pmwiki/pmwiki.php?n=Linux-next.FAQ )

I still got below build error in today's linux-next tree.
CC drivers/dma/imx-sdma.o
drivers/dma/imx-sdma.c:336: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:336: warning: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE'
drivers/dma/imx-sdma.c:336: warning: parameter names (without types)
in function declaration
drivers/dma/imx-sdma.c:343: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:343: warning: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE'
drivers/dma/imx-sdma.c:343: warning: parameter names (without types)
in function declaration
drivers/dma/imx-sdma.c: In function 'sdma_get_firmware':
drivers/dma/imx-sdma.c:1193: error: 'THIS_MODULE' undeclared (first
use in this function)
drivers/dma/imx-sdma.c:1193: error: (Each undeclared identifier is
reported only once
drivers/dma/imx-sdma.c:1193: error: for each function it appears in.)
drivers/dma/imx-sdma.c: At top level:
drivers/dma/imx-sdma.c:1457: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1457: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1457: warning: type defaults to 'int' in
declaration of 'MODULE_AUTHOR'
drivers/dma/imx-sdma.c:1457: warning: function declaration isn't a prototype
drivers/dma/imx-sdma.c:1458: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1458: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1458: warning: type defaults to 'int' in
declaration of 'MODULE_DESCRIPTION'
drivers/dma/imx-sdma.c:1458: warning: function declaration isn't a prototype
drivers/dma/imx-sdma.c:1459: error: expected declaration specifiers or
'...' before string constant
drivers/dma/imx-sdma.c:1459: warning: data definition has no type or
storage class
drivers/dma/imx-sdma.c:1459: warning: type defaults to 'int' in
declaration of 'MODULE_LICENSE'
drivers/dma/imx-sdma.c:1459: warning: function declaration isn't a prototype
make[2]: *** [drivers/dma/imx-sdma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/