Re: [PATCH 1/2] posix-timers: move global timer id management tosignal_struct v4

[Eric Dumazet]

Le lundi 19 septembre 2011 Ã 16:11 -0700, Andi Kleen a Ãcrit :
> > I'll provide not a hack but a clean patch for this.
> 
> Great thanks.
> > I read once idr code, and its not messy at all.
> You're not serious right? Especially the locking scheme is just
> a extreme mess:
> 
> sometimes takes a lock, sometimes requires locking from the caller
> even though the internal lock should be fine, sometimes uses unlocked 
> bitmap
> operations outside a lock, all mixed with a partial RCU implementation,
> no assumption is documented of course.  etc.etc. It's a great poster child
> for messy kernel code.
> 

I dont know, I met more complex code in kernel, but I wont say where ;)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/