RE: [PATCH] arch/x86/mm/numa.c: quiet sparse noise whenCONFIG_X86_64 is not set

[H Hartley Sweeten]

On Saturday, September 10, 2011 6:06 PM, Tejun Heo wrote:
> Hello,
>
> On Sat, Sep 10, 2011 at 02:39:02AM -0700, David Rientjes wrote:
>> On Fri, 9 Sep 2011, H Hartley Sweeten wrote:
>> 
>>> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
>>> index fbeaaf4..11c60a7 100644
>>> --- a/arch/x86/mm/numa.c
>>> +++ b/arch/x86/mm/numa.c
>>> @@ -455,6 +455,7 @@ void __init numa_set_distance(int from, int to, int distance)
>>>  	numa_distance[from * numa_distance_cnt + to] = distance;
>>>  }
>>>  
>>> +#ifdef CONFIG_X86_64
>>>  int __node_distance(int from, int to)
>>>  {
>>>  	if (from >= numa_distance_cnt || to >= numa_distance_cnt)
>>> @@ -462,6 +463,7 @@ int __node_distance(int from, int to)
>>>  	return numa_distance[from * numa_distance_cnt + to];
>>>  }
>>>  EXPORT_SYMBOL(__node_distance);
>>> +#endif
>>>  
>>>  /*
>>>   * Sanity check to catch more bad NUMA configurations (they are amazingly
>>> 
>>
>> What is 64-bit specific about this function?  Shouldn't we be defining it 
>> to be node_distance for all of x86?
>
> Yeap, that's a remnant of the old separate code paths, which wasn't
> discovered because asm-generic/topology.h defines fallback
> node_distance() automatically.  We should drop #ifdef from
> arch/x86/include/asm/topology.h::node_distance().  Hartley, can you
> please send a patch to do that?

Tejun,

I just posted the new patch, "x86: use the same node distance for 32 and 64-bit".

Thanks,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/