Re: [RFC][PATCH 4/5] printk: Have wake_up_klogd() use__this_cpu_write()

From: Christoph Lameter
Date: Mon Sep 19 2011 - 17:55:07 EST


On Mon, 19 Sep 2011, Steven Rostedt wrote:

> From: Steven Rostedt <srostedt@xxxxxxxxxx>
>
> The wake up code that triggers klogd does not really matter which
> CPU it enables the wake up on. Every CPU will be doing a printk_tick()
> and check the current CPU. As long as one of the CPUs triggers the
> wakeup we are fine. Use __this_cpu_write() instead of this_cpu_write()
> to show that we do not care.

printk_needs_cpu() is always called from context where we have disabled
interrupts therefore this is safe to do.

Reviewed-by: Christoph Lameter <cl@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/