Re: [PATCH v2 1/7] Basic kernel memory functionality for the MemoryController

From: Glauber Costa
Date: Sun Sep 18 2011 - 16:40:57 EST


On 09/18/2011 05:39 PM, Kirill A. Shutemov wrote:
On Sun, Sep 18, 2011 at 04:11:21PM -0300, Glauber Costa wrote:
On 09/18/2011 04:05 PM, Kirill A. Shutemov wrote:
On Sun, Sep 18, 2011 at 12:39:12AM -0300, Glauber Costa wrote:
Always zero in root cgroup?

Yes, if we're not accounting, it should be zero. WARN_ON, maybe?

-ENOSYS?

I'd personally prefer WARN_ON. It is good symmetry from userspace PoV to
always be able to get a value out of it. Also, it something goes wrong
and it is not zero for some reason, this will help us find it.

What's the point to get non-relevant value?
What about -ENOSYS + WARN_ON?

Well,

what about not even registering kernel memory files for !root cgroup?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/