Re: [PATCH] Return -EIO when xfs_vn_getattr() failed

From: Christoph Hellwig
Date: Sun Sep 18 2011 - 16:00:06 EST


On Sat, Sep 17, 2011 at 10:38:38PM +0900, Mitsuo Hayasaka wrote:
> An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
> Currently it returns EIO, not negative value, when it failed.
> As a result, the system call returns not negative value even though
> an error occured. The stat(2), ls and mv commands cannot handle this
> error and do not work correctly.
>
> This patch fixes this bug, and returns -EIO, not EIO when an error
> is detected in xfs_vn_getattr().

Indeed. Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/