Re: [PATCH v2] dmaengine: add CSR SiRFprimaII DMAC driver

[Jassi Brar]

On 17 September 2011 20:27, Barry Song <21cnbao@xxxxxxxxx> wrote:
>>> +static int sirfsoc_dma_slave_config(struct sirfsoc_dma_chan *schan,
>>> +       struct dma_slave_config *config)
>>> +{
>>> +       u32 addr, direction;
>>> +       unsigned long flags;
>>> +
>>> +       switch (config->direction) {
>>> +       case DMA_FROM_DEVICE:
>>> +               direction = 0;
>>> +               addr = config->dst_addr;
>>> +               break;
>>> +
>>> +       case DMA_TO_DEVICE:
>>> +               direction = 1;
>>> +               addr = config->src_addr;
>>> +               break;
>>> +
>>> +       default:
>>> +               return -EINVAL;
>>> +       }
>>> +
>>> +       if ((config->src_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
>>> +               (config->dst_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES))
>>> +               return -EINVAL;
>>> +
>>> +       spin_lock_irqsave(&schan->lock, flags);
>>> +       schan->addr = addr;
>>> +       schan->direction = direction;
>>> +       schan->mode = (config->src_maxburst == 4 ? 1 : 0);
>>> +       spin_unlock_irqrestore(&schan->lock, flags);
>>> +
>>> +       return 0;
>>> +}
>> You don't need to pass as much info via dma_slave_config as you do here.
>>
>> dmaxfer_template.src_inc  && !dmaxfer_template.dst_inc  => DMA_TO_DEVICE
>> !dmaxfer_template.src_inc  && dmaxfer_template.dst_inc  => DMA_FROM_DEVICE
>
> it seems direct DMA_TO_DEVICE/DMA_FROM_DEVICE is more feasible and
> explict to me.

> "dmaxfer_template.src_inc  && !dmaxfer_template.dst_inc" is probably
> DMA_TO_DEVICE, but it is not always true for all scenerios to all kinds of devices.
For which scenarios do you think it won't hold (remember that dmac already
knows if the channel is SLAVE or not) ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/