Re: [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request.

[Tao Ma]

On 09/15/2011 07:28 PM, Jens Axboe wrote:
> On 2011-09-15 13:17, Christoph Hellwig wrote:
>> On Thu, Sep 15, 2011 at 10:16:02AM +0800, Tao Ma wrote:
>>>> why not delete bio_set_completion_cpu()?
>>> Not sure. It is added in commit c7c22e4d from the very beginning, and in
>>> the commit log Jens described it as:
>>> A bio helper (bio_set_completion_cpu()) is also added, so that queuers
>>> can ask for completion on that specific CPU. Maybe it is obsolete.
>>> Anyway, I am fine to generate a patch to remove it if you prefer.
>>>> 1. nobody uses it in my search
>>> yes, but it may be designed for someone to use it. The same goes with
>>> BIO_CPU_AFFINE.
>>
>> This code is unused, and from the all the discussions lately pretty
>> obviously broken.  The only thing keeping it serves is creating more
>> confusion and possibly more bugs.
> 
> We can kill bio_set_completion_cpu(). I'm fine with leaving cpu control
> to the request based drivers, they are the only ones that can toggle the
> setting anyway.
So we should remove bio_comp_cpu and BIO_CPU_AFFINE also if we have
decided to only leave cpu control to the request based drivers, right?

I will generate a patch for it later.

Thanks
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/