Re: [PATCH 1/2] mfd: ab5500 chip register access

[Samuel Ortiz]

Hi Mattias,

On Thu, Jun 09, 2011 at 12:50:40PM +0200, Mattias Wallin wrote:
> The analog baseband chip ab5500 is a multi functional chip
> containing regulators, charging, gpio, USB and accessory detect.
> It also contain various multimedia functionalities like digital
> encoder and audio codec.
> The core driver added with this patch provides register access via
> i2c via PRCMU. Event handling implemented as irq_chip will come in
> future patches since it depends on PRCMU functionality not yet
> implemented.
This patch looks good to me. However, I think the 800 lines of debugfs code
could live in an ab5500-debugfs.c file. Could you please do that ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/